After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781462 - Do not suspend VMs while they're being installed
Do not suspend VMs while they're being installed
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
3.24.x
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-04-18 17:46 UTC by Fabiano Fidêncio
Modified: 2017-04-23 18:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vm-creator: Set run-in-background during install (1.60 KB, patch)
2017-04-20 12:12 UTC, Felipe Borges 		committed Details | Review

Description Fabiano Fidêncio 2017-04-18 17:46:48 UTC 
A user may end up losing its whole installation in case they close GNOME Boxes for any reason.
Comment 1 Felipe Borges 2017-04-20 12:12:46 UTC 
Created attachment 350119 [details] [review]
vm-creator: Set run-in-background during install

An ongoing installation could be interrupted by Boxes window
being closed or an application crash because we are suspending
the VMs in the GtkApplication vfunc_shutdown method.

In doing so, let's set a VM to run in background during its
installation so it doesn't get suspended.
Comment 2 Fabiano Fidêncio 2017-04-20 22:17:18 UTC 
(In reply to Felipe Borges from comment #1)
> Created attachment 350119 [details] [review] [review]
> vm-creator: Set run-in-background during install
> 
> An ongoing installation could be interrupted by Boxes window
> being closed or an application crash because we are suspending
> the VMs in the GtkApplication vfunc_shutdown method.
> 
> In doing so, let's set a VM to run in background during its
> installation so it doesn't get suspended.

Patch look goods to me. Just let me run some tests over the weekend and then I'll ACK it accordingly to the tests results.
Comment 3 Fabiano Fidêncio 2017-04-22 21:27:51 UTC 
Review of attachment 350119 [details] [review]:

Patch does work as expected.
Comment 4 Felipe Borges 2017-04-23 18:17:29 UTC 
Thanks!


Attachment 350119 [details] pushed as 07b9f37 - vm-creator: Set run-in-background during install