After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781455 - lokview: LOKDocView.View.new accepts 2 arguments, not 3
lokview: LOKDocView.View.new accepts 2 arguments, not 3
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-04-18 15:05 UTC by Debarshi Ray
Modified: 2017-04-18 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
lokview: LOKDocView.View.new accepts 2 arguments, not 3 (843 bytes, patch)
2017-04-18 15:20 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-04-18 15:05:57 UTC 
With SpiderMonkey 38 and the gjs-1.48.x, I see these when using LOKDocView:

  JS WARNING: [resource:///org/gnome/Documents/js/lokview.js 133]:
    Too many arguments to function LOKDocView.new: expected 2, got 3

The C API looks like this:

GtkWidget *lok_doc_view_new (const gchar* pPath,
                             GCancellable *cancellable,
                             GError **error)
Comment 1 Debarshi Ray 2017-04-18 15:20:46 UTC 
Created attachment 350008 [details] [review]
lokview: LOKDocView.View.new accepts 2 arguments, not 3
Comment 2 Cosimo Cecchi 2017-04-18 16:36:56 UTC 
Review of attachment 350008 [details] [review]:

Thanks, looks good.