GNOME Bugzilla – Bug 781452
gnome-mud: Doesn't reallow NAWS if disabled
Last modified: 2017-12-06 16:29:18 UTC
I'm building a mud server that allows the NAWS option to be dynamically enabled and disabled at runtime at the request of the user. However, with gnome-mud if I ever send a DONT, even once, gnome-mud gets stuck hating it and always sends back a WONT every time the server tries to reenable it. This is frustrating. It is hampering debugging server side handling of NAWS.
Do you happen to know of another server which has a dynamic NAWS configuration I could test against, or is your server available to use for testing? I will add some unit tests if nothing is available immediately, which would be best anyway. If you aren't building Gnome Mud yourself then it's likely going to be a long time before you see a fix for this. I'll try and get a patch for you soon if I'm able to reproduce it though.
noticed that the handler for NAWS starts out enabled. If I attempt to send a DONT, it just gets ignored. if I have the server turn it on, everything works as expected. However, if I have the server turn it back OFF, the handler gets disabled entirely, which makes gnome-mud think it doesn't support the option at all. I noticed a few other telnet options that probably would get permanently disabled the same way. My suggestion is to not disable the handler, just the option. ---- As for reproducing this, can you poke me on irc.gnome.org to get a hostname and port for connection?
I can give you connection info for my server but I'd rather not disclose it publicly right now in case some script kiddie decides to try ddosing me.
Created attachment 350058 [details] [review] Fix re-enabling disabled TELOPTS Thanks shentino. I've attached a patch for the GNOMEMUD_0_11_2 tag. The issue isn't present in the master branch.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-mud/issues/19.