After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781448 - time-selector: set the right lower bound
time-selector: set the right lower bound
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-18 12:22 UTC by Mohammed Sadiq
Modified: 2017-04-18 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
time-selector: set the right lower bound (1.33 KB, patch)
2017-04-18 12:22 UTC, Mohammed Sadiq 		committed Details | Review

Description Mohammed Sadiq 2017-04-18 12:22:44 UTC 
.
Comment 1 Mohammed Sadiq 2017-04-18 12:22:59 UTC 
Created attachment 349995 [details] [review]
time-selector: set the right lower bound

There was a typo in function name, which was only setting
the upper bound for 24 hour time format. As the default
lower bound is 0, no issue was known so far.

But in cases like the user switched from 12 hour to 24 hour
format there is a chance for some issues to appear as the lower
bound of 12 Hour format is 1, and it won't be reset to 0 when
the user has switched to 24 hour format.
Comment 2 Georges Basile Stavracas Neto 2017-04-18 12:33:15 UTC 
Review of attachment 349995 [details] [review]:

LGTM
Comment 3 Georges Basile Stavracas Neto 2017-04-18 12:34:37 UTC 
Thanks for the patch!

Attachment 349995 [details] pushed as cf787ea - time-selector: set the right lower bound