GNOME Bugzilla – Bug 781437
rtspsrc: set npt-stop to segment stop time
Last modified: 2018-11-03 15:18:22 UTC
In seekable rtsp playback, the ntp-start/stop value used for indicating starting/ending time of segment. The ntp-stop was always set to the segment->duration, so fixed it to set segment.stop when it is valid value. This can make segment seeking on rtsp playback.
Created attachment 349985 [details] [review] rtspsrc: Set ntp-stop to segment stop time
Comment on attachment 349985 [details] [review] rtspsrc: Set ntp-stop to segment stop time Makes sense, but for the old case... wouldn't stop = segment->start + segment->duration make more sense? Do you have a testcase for reproducing the problem here, e.g. with gst-plugins-base/tests/examples/playback on a simple gst-rtsp-server?
Created attachment 350100 [details] [review] rtspsrc: Set ntp-stop to segment stop time #2 (In reply to Sebastian Dröge (slomo) from comment #2) > Comment on attachment 349985 [details] [review] [review] > rtspsrc: Set ntp-stop to segment stop time > > Makes sense, but for the old case... wouldn't stop = segment->start + > segment->duration make more sense? Yes that make more sense, fixed it to set segment->start + segment->duration in that case, thanks. > > Do you have a testcase for reproducing the problem here, e.g. with > gst-plugins-base/tests/examples/playback on a simple gst-rtsp-server? I tested it with rtsp://184.72.239.149/vod/mp4:BigBuckBunny_115k.mov , but I don't have a testcase what can share now. The playback example seems to be needed some work to set stop position for segment seek.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/365.