After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781425 - gstrtpL16pay: added S16LE format to caps
gstrtpL16pay: added S16LE format to caps
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Mac OS
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-17 20:27 UTC by Gabriel Sosa
Modified: 2018-05-06 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Added S16LE format to caps in gstrtpL16pay.c (816 bytes, patch)
2017-04-17 20:27 UTC, Gabriel Sosa 		rejected Details | Review

Description Gabriel Sosa 2017-04-17 20:27:28 UTC 
Created attachment 349964 [details] [review]
Added S16LE format to caps in gstrtpL16pay.c

Added S16LE format to caps in gstrtpL16pay.
Comment 1 Sebastian Dröge (slomo) 2017-04-17 20:35:10 UTC 
Review of attachment 349964 [details] [review]:

::: gst/rtp/gstrtpL16pay.c
@@ +54,3 @@
     GST_PAD_ALWAYS,
     GST_STATIC_CAPS ("audio/x-raw, "
+        "format = (string) { \"S16BE\", \"S16LE\" }, "

At the receiver-side there would be no way of distinguishing LE and BE, and the RFC (https://tools.ietf.org/html/rfc3551) specifies only big endian (https://tools.ietf.org/html/rfc3551#section-4.5.11 "network byte order")
Comment 2 Sebastian Dröge (slomo) 2017-04-17 20:37:22 UTC 
Thanks for your patch, but at least with the existing RTP RFC this is not compatible. There might be another RFC that allows sending little-endian raw audio, and in that case we could add support for that.

Also note that rtpgstpay/depay supports sending anything that is expressible with GStreamer caps, which might be enough in your case if both receiver and sender are GStreamer-based. Or is there any other software that is producing/accepting these streams, and if so which and based on which RFC?
Comment 3 Vivia Nikolaidou 2018-05-06 12:55:24 UTC 
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment.
Thanks!