After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781422 - translate_wm_button_layout_to_gtk() is licensed under the GPL
translate_wm_button_layout_to_gtk() is licensed under the GPL
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other All
: Normal major
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-04-17 19:30 UTC by A. Walton
Modified: 2017-05-08 21:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdk: Relicense translate_wm_button_layout_to_gtk() (3.20 KB, patch)
2017-04-22 18:01 UTC, Florian Müllner
accepted-commit_now Details | Review

Description A. Walton 2017-04-17 19:30:30 UTC
VMware legal unearthed a GPL licensed file during our open source license validation steps for shipping a product with Gtk+ 3.x for the first time: gtk+/gdk/wayland/wm-button-layout-translation.c. It appears to only export the translate_wm_button_layout_to_gtk() symbol, but does so under the GPLv2:

<<<
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
 *
 * Copyright (C) 2014 Red Hat, Inc.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, see <http://www.gnu.org/licenses/>.
 *
 * Author:  Florian Müllner <fmuellner@gnome.org>
 */
#ifndef __WM_BUTTON_LAYOUT_TRANSLATION__
#define __WM_BUTTON_LAYOUT_TRANSLATION__

void translate_wm_button_layout_to_gtk (char *layout);

#endif
>>>

We aren't *incredibly* worried about this at the moment, as we cannot currently enable the wayland backend for our shipped version of the library anyway, but it will come up as an issue if and when we get there. Others may be much more worried...
Comment 1 Matthias Clasen 2017-04-22 16:54:14 UTC
Florian, I think this is your code - willing to relicense it ?
Comment 2 Florian Müllner 2017-04-22 18:01:40 UTC
Created attachment 350245 [details] [review]
gdk: Relicense translate_wm_button_layout_to_gtk()

It is generally a good idea to license individual files under the
same terms as the project license (in particular when the mismatch
boils down to having copied the wrong license header), so relicense
the code under the LGPL.
Comment 3 Matthias Clasen 2017-04-27 17:58:15 UTC
Review of attachment 350245 [details] [review]:

thanks. can you push this to gtk-3-22 as well, please ?