After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781364 - Default location is not marked for translation
Default location is not marked for translation
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2017-04-16 12:34 UTC by Piotr Drąg
Modified: 2017-12-01 16:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Mark the default location for translation (1.12 KB, patch)
2017-04-16 12:35 UTC, Piotr Drąg 		committed Details | Review

Description Piotr Drąg 2017-04-16 12:34:29 UTC 
Since commit a273fe8b, the default location in the GSchema file is no longer marked for translation. The translator comment is still there, so I presume it’s not intentional. Plus, it makes sense to replace New York with something closer to the user.
Comment 1 Piotr Drąg 2017-04-16 12:35:52 UTC 
Created attachment 349900 [details] [review]
Mark the default location for translation
Comment 2 Bastien Nocera 2017-12-01 14:45:24 UTC 
Review of attachment 349900 [details] [review]:

Looks correct. Can you please verify that it still works as expected with the new Meson build system?
Comment 3 Piotr Drąg 2017-12-01 15:12:01 UTC 
What exactly do you want me to test? It does compile.
Comment 4 Bastien Nocera 2017-12-01 16:00:54 UTC 
(In reply to Piotr Drąg from comment #3)
> What exactly do you want me to test? It does compile.

That it fixes the original bug, so that the setting is marked for translation in the generated pot file.
Comment 5 Piotr Drąg 2017-12-01 16:04:25 UTC 
Comment on attachment 349900 [details] [review]
Mark the default location for translation

Yes, it does.

Pushed: https://git.gnome.org/browse/libgweather/commit/?id=5901c17d94007e90d8ab9b8d4ba0e1eca47c0f5a