GNOME Bugzilla – Bug 781340
Tests / "make check" fail on Mageia v6 x86-64
Last modified: 2017-06-27 13:05:10 UTC
Created attachment 349887 [details] [review] A patch to fix some of the problems. make check fails here on Mageia Linux v6 x86-64. I'll soon attach a patch I used to fix some of them and the output of make check.
Created attachment 349888 [details] Output of "make check" on my system.
The test is useful also without the added text which relies on freetype as well as installed fonts for making the same output. The change to gegl-imgcmp might still be desirable though. commit e1049601b997c76c5e75b5eb3a07c6402abc6f82 Author: Øyvind Kolås <pippin@gimp.org> Date: Thu May 4 18:04:08 2017 +0200 tests: remove text from gegl test This should fix bug #781340
(In reply to Øyvind Kolås from comment #2) > The test is useful also without the added text which relies on freetype as > well as installed fonts for making the same output. The change to > gegl-imgcmp might still be desirable though. > > commit e1049601b997c76c5e75b5eb3a07c6402abc6f82 > Author: Øyvind Kolås <pippin@gimp.org> > Date: Thu May 4 18:04:08 2017 +0200 > > tests: remove text from gegl test > > This should fix bug #781340 where can I find this commit? It's not here - https://git.gnome.org/browse/GEGL/commit/?id=e1049601b997c76c5e75b5eb3a07c6402abc6f82 . Thanks!
It is there now - I posted the comment without knowing that the git push had completed successfully.
(In reply to Øyvind Kolås from comment #4) > It is there now - I posted the comment without knowing that the git push had > completed successfully. Thanks! Unfortunately, tests are still failing. I'll attach the new diff and make check output soon.
Created attachment 351066 [details] [review] New patch against the working copy
Created attachment 351067 [details] make check output on mageia v6 x86-64.
Comment on attachment 351066 [details] [review] New patch against the working copy The part referring to fonts and special casing gegl.xml should not be needed any more - there is not font-rendering going on in the output of this test https://git.gnome.org/browse/gegl/plain/tests/compositions/reference/gegl.png anymore.
Created attachment 351311 [details] [review] Extra-new patch against the working copy - same failure This is an extra-new patch against the working copy with Oyvind's comments incorporated. I am still getting the same failure.
It is a different failure from the one reported in this bug though, failing for the color-reduction.xml test not gegl.xml. I am starting to wonder if the default make check/distcheck of GEGL should be more relaxed about passing tests comparing pixel by pixel expected output, or maybe add an ability to configure the build to skip compositions tests. The even more hairline triggering tests in docs are not breaking the build anymore, even if they still are reporting.
(In reply to Øyvind Kolås from comment #10) > It is a different failure from the one reported in this bug though, failing > for the color-reduction.xml test not gegl.xml. > Thanks for the analysis. > I am starting to wonder if the default make check/distcheck of GEGL should > be more relaxed about passing tests comparing pixel by pixel expected > output, or maybe add an ability to configure the build to skip compositions > tests. The even more hairline triggering tests in docs are not breaking the > build anymore, even if they still are reporting.
The color-reduction.xml tests is still failing on mageia v6. What should we do?
I'd suggest closing this bug and opening a bug about the "color-reduction test failing". Since the title of this bug is misleading - making it hard to find, and the issue of the original report and first comments are about a different issue.
Original issue is resolved, closing this and awaiting a new bug report with cleaner comment history.