GNOME Bugzilla – Bug 781258
Invalid JSON in manifest breaks some parsers
Last modified: 2017-04-14 09:42:55 UTC
The manifest for flatpak contains invalid syntax for C-style comments, and this breaks some parsers.
Created attachment 349780 [details] [review] Patch to remove invalid comment syntax
Created attachment 349785 [details] [review] Patch to remove invalid comment syntax gitg is bugged and doesn't add commit or author to the .patch file. Here's the fixed one.
Review of attachment 349785 [details] [review]: Code looks good. Did you try it works now? The commit message needs to use present "Remove" instead of "Removed" Also, the important part of this is that C style comments in JSON are just invalid syntax, and as a consecuence tools that doesn't use json-glib break, like python json parsers used for example in flatpak-dev-cli.
Created attachment 349786 [details] [review] Patch to remove invalid comment syntax Fixed my commit message.
Review of attachment 349786 [details] [review]: Commit description is now good, but you are missing the file you modified in the tittle
Created attachment 349843 [details] [review] Patch to remove invalid comment syntax Should be fixed. I'm sorry for all of the mistakes in the commit message.
Review of attachment 349843 [details] [review]: Now looks good to me, congrats Zack!! Your first contribution :)
Georges, don't be angry at me I push this patch. Otherwise the CLI tool for developing from Flatpak breaks, and newcomers cannot build gnome-todo. Feel free to revert/discuss with me if you think so!
And for some reason git bz failed :/ Here's the commit https://git.gnome.org/browse/gnome-todo/commit/?id=68661617c04c8d48fdefe8aa9d3cc631d1d54e3b
I'm not angry, thanks for fixing that :)