After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781246 - Return value of gtk_widget_get_parent_window should be marked (nullable)
Return value of gtk_widget_get_parent_window should be marked (nullable)
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Language Bindings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-04-13 05:21 UTC by Iñaki García Etxebarria
Modified: 2017-08-03 19:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch fixing the introspection data (792 bytes, patch)
2017-04-13 05:27 UTC, Iñaki García Etxebarria
committed Details | Review

Description Iñaki García Etxebarria 2017-04-13 05:21:40 UTC
This function can return NULL, but the corresponding annotation is missing.
Comment 1 Iñaki García Etxebarria 2017-04-13 05:27:51 UTC
Created attachment 349761 [details] [review]
Patch fixing the introspection data
Comment 2 Timm Bäder 2017-06-06 11:59:23 UTC
Review of attachment 349761 [details] [review]:

While correct based on the return statement at the end of the function, we always try to also explain when the returned value is NULL (except on precondition failures).