GNOME Bugzilla – Bug 781214
define entry-tag in Adwaita.
Last modified: 2017-05-11 13:28:19 UTC
When searching, scope is shown as tags in the search entry. This is currently style in individual applications as documents-entry-tag and photos-entry-tag for example. Would be nice to define it in adwaita as entry-tag.
Created attachment 349832 [details] [review] style entry-tags
Jakub, not sure about the background color, darkening $bg_color 20% on a the dark variant won't probably work that nicelly ($base_color is darker then $bg_color there), also to reset the button we have a nice mixin (button(undecorated) or something IIRC), please use that one.
also, backdrop state?
Created attachment 350103 [details] [review] style entry-tags
Jimmac is OK with having styling for libgd widgets in gtk+, so this doesn't depend on bug 756353.
Review of attachment 350103 [details] [review]: The code looks good to me. However, we will need to change the style class in libgd for this to work. When doing that, libgd currently also adds a CSS provider with the default theming for the entry tag, which should be removed as part of this.
Attachment 350103 [details] pushed as dee666f - style entry-tags
Review of attachment 350103 [details] [review]: Is this all that is to it? I can't get gnome-documents/photos.git master to pick up the new entry-tag styling. I did install sassc and rebuilt gtk-3-22 and my config.log says: configure:29158: checking for sassc configure:29176: found /usr/bin/sassc configure:29188: result: /usr/bin/sass Is this a matter of having an entry-tag CSS style class, as opposed to just a CSS node? Nodes are not available to out-of-tree widgets.
The entry-tag looks pretty ugly in context, reopening. I'll work on a better style, but the entry itself has some issue, e.g. it doesn't seem to respond to :dir(rtl) for example and I'd like to know if the entry tag styling is just for the libgd implementation, if it is I can fix some specific issue, like spacing and placement with some kind of gross hack in adwaita (read negative margins to componsate entry padding for a better placement)
Created attachment 351622 [details] [review] *scss only* patch There's my proposed styling, I used a blue on the bright variant, similar to what gnome-documents was shipping and a gray for the dark variant, which looks more usable to me. There are some quirks with the entry-tag implementation though, the tag close button doesn't get the right style until is hovered and the active state on that button remains stuck in certain cases.
Pushed to master and 3.22, closing, please reopen in case of issues (with the style, otherwise blame Debarashi :-))