After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781213 - validate: Do not expect switching tracks in PAUSED to happen synchronously with playbin3
validate: Do not expect switching tracks in PAUSED to happen synchronously wi...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
unspecified
Other All
: Normal normal
: 1.11.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-12 10:53 UTC by Edward Hervey
Modified: 2017-04-12 14:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
validate: Don't attempt switching tracks in PAUSED with playbin3 (2.53 KB, patch)
2017-04-12 10:53 UTC, Edward Hervey
none Details | Review
validate: Don't attempt switching tracks in PAUSED with playbin3 (2.53 KB, patch)
2017-04-12 12:13 UTC, Edward Hervey
none Details | Review
validate: Do not expect track switch to be synchronous for playbin3 (2.49 KB, patch)
2017-04-12 14:28 UTC, Thibault Saunier
none Details | Review

Description Edward Hervey 2017-04-12 10:53:26 UTC
See commit
Comment 1 Edward Hervey 2017-04-12 10:53:32 UTC
Created attachment 349717 [details] [review]
validate: Don't attempt switching tracks in PAUSED with playbin3

With decoebin3 the switch is asynchronous, so it won't work if streams
are blocking/prerolling
Comment 2 Sebastian Dröge (slomo) 2017-04-12 11:43:24 UTC
Comment on attachment 349717 [details] [review]
validate: Don't attempt switching tracks in PAUSED with playbin3

Typo in commit message


But the same is also true for decodebin2, this is never synchronous
Comment 3 Edward Hervey 2017-04-12 12:12:55 UTC
> But the same is also true for decodebin2, this is never synchronous

Was pretty certain the stream-selector flushes downstream and sends a new stream-start event.
Comment 4 Edward Hervey 2017-04-12 12:13:32 UTC
Created attachment 349720 [details] [review]
validate: Don't attempt switching tracks in PAUSED with playbin3

With decodebin3 the switch is asynchronous, so it won't work if streams
are blocking/prerolling
Comment 5 Thibault Saunier 2017-04-12 12:28:47 UTC
> But the same is also true for decodebin2, this is never synchronous

I think I got it working and added the test so it should be working for decodebin2.
Comment 6 Thibault Saunier 2017-04-12 14:28:56 UTC
Created attachment 349735 [details] [review]
validate: Do not expect track switch to be synchronous for playbin3

And let following actions to be executed (setting the action as
INTERLACED) which will make sure the track switch happened at some
point. It means the user has to set the pipeline to PLAYING so we can
make it works but we do not have choice here I think
Comment 7 Thibault Saunier 2017-04-12 14:31:50 UTC
Attachment 349735 [details] pushed as 26b388c - validate: Do not expect track switch to be synchronous for playbin3