Created attachment 349663 [details] [review]
systemd: Throw a descriptive warning if badly setup

Instead of throwing:
GLib-GIO-CRITICAL: g_dbus_connection_call_internal: assertion 'object_path != NULL && g_variant_is_object_path (object_path)' failed
Throw a warning explaining why we got into this situation.

Experienced while working on gnome-settings-daemon's power test suite.
The new error message is more descriptive than the original
warning/assertion.

Review of attachment 349663 [details] [review]:

this is probably fine, but one thing i'm worried about is the message potentially getting printed over and over again. it looks like we already warn up front, though:

        if (manager->priv->session_id == NULL) {•
                g_warning ("Could not get session id for session. Check that logind is "•
                           "properly installed and pam_systemd is getting used at login.");•
                return;•


So maybe just return without the g_warning? but whatever you want to do.

(In reply to Ray Strode [halfline] from comment #2)
> Review of attachment 349663 [details] [review] [review]:
> 
> this is probably fine, but one thing i'm worried about is the message
> potentially getting printed over and over again.

I think you'd find out pretty fast that gnome-session wasn't working, and it replaces an inscrutable looping warning with a readable one. So I'll push that, and we'll see if somebody complains about it later.

Created attachment 352861 [details] [review]
systemd: Add more details to systemd setup error

By adding the contents of the error reported.

Attachment 349663 [details] pushed as 015c142 - systemd: Throw a descriptive warning if badly setup
Attachment 352861 [details] pushed as fd122ed - systemd: Add more details to systemd setup error