GNOME Bugzilla – Bug 781164
Try to follow HIG with ellipses
Last modified: 2017-04-11 01:29:22 UTC
Here's a patch to add ellipses where more action is needed and remove ellipses where the user might just want to view something. The app menu's Import and Export Bookmarks probably could use ellipses too so I can submit a patch for that if you want. It's more rare to see ellipses in that menu so that's why I hesitated.
Created attachment 349645 [details] [review] Try to follow HIG with ellipses
Created attachment 349646 [details] [review] Add destructive-action style to Remove Language button Since this is a permanent "destructive" action, style it accordingly. If you don't like the bright red color here, you could re-do this dialog to use symbolic +, -, ^ and down icons at the bottom instead. We so far don't use bright red coloring in that case (although maybe it's worth looking into whether we should?)
Review of attachment 349645 [details] [review]: Let's avoid ellipses in the app menu unless that becomes more popular with other apps first.
Review of attachment 349646 [details] [review]: Using this style here feels like overkill to me. Your suggestion about redoing the dialog to avoid the text buttons entirely seems good, but that's more work of course.
Attachment 349645 [details] pushed as 27cc337 - Try to follow HIG with ellipses