GNOME Bugzilla – Bug 781123
Handling emoji presentation 0xfe0e and 0xfe0f
Last modified: 2017-05-23 04:01:22 UTC
0xfe0e and 0xfe0f are emoji presentation of emoji text mode and color mode. [1] "Noto Color Emoji" font does not include 0xfe0f so current Pango draws the sequence of "0x0023 fe0f 20e3" as two characters since fe0f is included in "DejaVu" font. I think fe0e and fe0f can be handled by Pango when a emoji font does not include them. What do you think about it? The following patch can draw the "0x0023 fe0f 20e3" as one char.
[1] http://www.unicode.org/emoji/charts/emoji-variants.html
Created attachment 349594 [details] [review] Patch for pango-context.c
See also: https://bugzilla.gnome.org/show_bug.cgi?id=780669
Checked "DejaVu Sans" and "Noto Color Emoji" fonts, it seems some fonts includes "DejaVu Sans" contain "0xFE0E" and "0xFE0F" vector glyphs, but "Noto Color Emoji" doesn't contain "0xFE0E" and "0xFE0F" glyphs. Another problem maybe: "DejaVu Sans" contains mostly vector glyphs, but "Noto Color Emoji" only contains color bitmap glyphs. pango seems to prefer to use vector glyphs over bitmap glyphs. I think Fujiwara San’s patch will ignore the fonts selected by "0xFE0E" and "0xFE0F" glyphs.
Created attachment 351520 [details] [review] Patch for pango-context.c Rephrased the patch.
We should at least do that for all Unicode Variation Selector characters.
Created attachment 352060 [details] [review] Patch for pango-context.c (In reply to Behdad Esfahbod from comment #6) > We should at least do that for all Unicode Variation Selector characters. I updated the patch.
Created attachment 352061 [details] [review] Patch for pango-context.c Forgot to obsolete the previous patch.
Review of attachment 352061 [details] [review]: Thanks. Can you also update the comment? Say we don't want to change font for variation selectors. Also, here's the full list of variation selectors: U+FE00..U+FE0F,U+E0100..U+E01EF
Created attachment 352342 [details] [review] Patch for pango-context.c (In reply to Behdad Esfahbod from comment #9) > Review of attachment 352061 [details] [review] [review]: > > Thanks. Can you also update the comment? Say we don't want to change font > for variation selectors. > > Also, here's the full list of variation selectors: > U+FE00..U+FE0F,U+E0100..U+E01EF I updated the patch.
Review of attachment 352342 [details] [review]: Thanks.
Could you commit my patch on behalf of me? I have no commit right after GNOME have switched to Git.
Done. Thanks.