After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781112 - pad-monitor: Safely store expected accurate seek value
pad-monitor: Safely store expected accurate seek value
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
unspecified
Other All
: Normal normal
: 1.11.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-10 06:03 UTC by Edward Hervey
Modified: 2017-04-10 07:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pad-monitor: Safely store expected accurate seek value (1.90 KB, patch)
2017-04-10 06:03 UTC, Edward Hervey
rejected Details | Review
pad-monitor: Safely store expected seek values (4.54 KB, patch)
2017-04-10 07:19 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2017-04-10 06:03:18 UTC
Fixes races with multiple seeks
Comment 1 Edward Hervey 2017-04-10 06:03:22 UTC
Created attachment 349583 [details] [review]
pad-monitor: Safely store expected accurate seek value

Protect the expected accurate seek value with the same lock as the one
that will be used to read/validate the resulting segment.

Avoids races with duplicated seeks
Comment 2 Edward Hervey 2017-04-10 06:10:38 UTC
It's still racy. Trying to figure it out
Comment 3 Edward Hervey 2017-04-10 07:19:18 UTC
Created attachment 349584 [details] [review]
pad-monitor: Safely store expected seek values

Protect the expected seek values with the same lock as the one
that will be used to read/validate the resulting segments and flush
values.

Avoids races with duplicated seeks (i.e. a seek that was already
sent and handled via another pad, such as in demuxers).
Comment 4 Edward Hervey 2017-04-10 07:24:29 UTC
commit b156616b5c424ee2c5d2f9aa6d233106f3fe97a4
Author: Edward Hervey <edward@centricular.com>
Date:   Mon Apr 10 07:58:01 2017 +0200

    pad-monitor: Safely store expected seek values
    
    Protect the expected seek values with the same lock as the one
    that will be used to read/validate the resulting segments and flush
    values.
    
    Avoids races with duplicated seeks (i.e. a seek that was already
    sent and handled via another pad, such as in demuxers).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=781112