After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781086 - todo.txt: fix possible memory leak
todo.txt: fix possible memory leak
Status: RESOLVED FIXED
Product: gnome-todo
Classification: Other
Component: Plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME To Do maintainer(s)
GNOME To Do maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-04-09 06:29 UTC by Mohammed Sadiq
Modified: 2017-04-20 15:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
todo.txt: fix possible memory leak (916 bytes, patch)
2017-04-09 06:29 UTC, Mohammed Sadiq 		none Details | Review
todo.txt: fix possible memory leak (1009 bytes, patch)
2017-04-20 15:33 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Mohammed Sadiq 2017-04-09 06:29:31 UTC 
.
Comment 1 Mohammed Sadiq 2017-04-09 06:29:48 UTC 
Created attachment 349549 [details] [review]
todo.txt: fix possible memory leak
Comment 2 Georges Basile Stavracas Neto 2017-04-20 15:29:44 UTC 
Review of attachment 349549 [details] [review]:

I think this patch can instead change the GDate to be stack-allocated. Like:

GDate date;

g_date_clear (&date);

...
Comment 3 Georges Basile Stavracas Neto 2017-04-20 15:33:50 UTC 
Created attachment 350141 [details] [review]
todo.txt: fix possible memory leak

Same patch using a stack-allocated GDate.
Comment 4 Georges Basile Stavracas Neto 2017-04-20 15:34:23 UTC 
Attachment 350141 [details] pushed as 32edb17 - todo.txt: fix possible memory leak