After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781053 - About dialog window is not modal
About dialog window is not modal
Status: RESOLVED FIXED
Product: sysprof
Classification: Other
Component: general
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: Sysprof maintainer(s)
Sysprof maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-04-08 12:44 UTC by Dimitrios Christidis
Modified: 2017-04-09 03:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
app: Make About dialog modal (1.03 KB, patch)
2017-04-08 12:45 UTC, Dimitrios Christidis 		accepted-commit_now Details | Review
window: add each instance to each own group (1.14 KB, patch)
2017-04-08 12:46 UTC, Dimitrios Christidis 		committed Details | Review

Description Dimitrios Christidis 2017-04-08 12:44:05 UTC 
This is the equivalent of bugs #776864 and #776865, but for Sysprof.

Making the About dialog modal increases consistency with other GNOME applications. Usability is not hindered because it is unlikely for the user to need to view the About dialog and the contents of the window simultaneously.
Comment 1 Dimitrios Christidis 2017-04-08 12:45:38 UTC 
Created attachment 349522 [details] [review]
app: Make About dialog modal
Comment 2 Dimitrios Christidis 2017-04-08 12:46:34 UTC 
Created attachment 349523 [details] [review]
window: add each instance to each own group
Comment 3 Christian Hergert 2017-04-08 19:14:17 UTC 
Review of attachment 349523 [details] [review]:

LGTM
Comment 4 Christian Hergert 2017-04-08 19:14:26 UTC 
Review of attachment 349522 [details] [review]:

LGTM
Comment 5 Christian Hergert 2017-04-09 03:30:14 UTC 
Thanks!

Attachment 349523 [details] pushed as 987f661 - window: add each instance to each own group