After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781043 - gl: gstglconfig.h differs in meson and autotools builds
gl: gstglconfig.h differs in meson and autotools builds
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.11.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-07 20:09 UTC by Scott D Phillips
Modified: 2017-04-09 08:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] meson: gl: set default value of 0 for glconf vars (3.01 KB, patch)
2017-04-07 20:09 UTC, Scott D Phillips 		committed Details | Review

Description Scott D Phillips 2017-04-07 20:09:40 UTC 
Created attachment 349503 [details] [review]
[PATCH] meson: gl: set default value of 0 for glconf vars

The autotools generated gstglconfig.h has all macros defined as either 0 or 1. In the meson build the macros are either defined as 1 or omitted and left undef by default.
Comment 1 Sebastian Dröge (slomo) 2017-04-09 08:21:32 UTC 
commit fc0c7d664d546a3b545e7c5b7bed392ea07babbf
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Fri Apr 7 12:19:27 2017 -0700

    meson: gl: set default value of 0 for glconf vars
    
    meson's configure_file emits only a comment like /* #undef ... */
    for values which are unset in the configuration_data. For
    gstglconfig.h, this differs from the autotools build where the
    preprocessor definitions are always either 0 or 1. So loop over a
    list of variables to set to zero as default.
    
    Also sync up the gstglconfig.h.meson file with the additional
    macros defined by the autotools build.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=781043