Created attachment 349438 [details] [review]
gst-plugins-bad.supp: add gl suppressions for one off init allocations

Review of attachment 349438 [details] [review]:

::: tests/check/gst-plugins-bad.supp
@@ +42,3 @@
+   fun:calloc
+   ...
+   fun:__pthread_once_slow

What is this leak exactly?

@@ +83,3 @@
+
+{
+   <dodgy one, seems like a xcb bug>

Did you report?

@@ +98,3 @@
+   fun:g_malloc0
+   ...
+   fun:call_init.part.0

What are these exactly? What do we leak there?

I did not report. The others are from once-only initializations. I will repro and post the stacks.

XCB:

==7611== 36 bytes in 1 blocks are definitely lost in loss record 980 of 1,709
==7611==    at 0x4C2AFA7: malloc (vg_replace_malloc.c:296)
==7611==    by 0x587B75B: ??? (in /usr/lib64/libxcb.so.1.1.0)
==7611==    by 0x58794E0: ??? (in /usr/lib64/libxcb.so.1.1.0)
==7611==    by 0x587AC26: ??? (in /usr/lib64/libxcb.so.1.1.0)
==7611==    by 0x587AD30: xcb_wait_for_reply (in /usr/lib64/libxcb.so.1.1.0)
==7611==    by 0x50E32C4: ??? (in /usr/lib64/libGL.so.1.2.0)
==7611==    by 0x50DE0B7: ??? (in /usr/lib64/libGL.so.1.2.0)
==7611==    by 0x50B29B0: ??? (in /usr/lib64/libGL.so.1.2.0)
==7611==    by 0x50AE180: glXQueryVersion (in /usr/lib64/libGL.so.1.2.0)
==7611==    by 0x4E6EE2A: gst_gl_context_glx_choose_format (gstglcontext_glx.c:356)
==7611==    by 0x4E4A6D1: gst_gl_context_create_thread (gstglcontext.c:1193)
==7611==    by 0x81A18E4: ??? (in /usr/lib64/libglib-2.0.so.0.4600.2)
==7611==    by 0x6BF8619: start_thread (in /usr/lib64/libpthread-2.22.so)
==7611==    by 0x856C5FC: clone (in /usr/lib64/libc-2.22.so)


I'm not sure what the first one was about. In my previous comment I was thinking of the several *_once ones, but I'll remove that one. The last suppression is, I suspect, from the dynamic loader.

Created attachment 349449 [details] [review]
gst-plugins-bad.supp: add gl suppressions for one off init allocations

Minus the first pthread_once, I can't recall which test threw it right now, it was a few days ago, I'll find out when I re-enable all through valgrind and post again if I still see it.

Added these to gst-plugins-base.supp, but without the trailing line referring to ld-2.22.so

commit 63a83768253bc5dbad500b506b5aca269ec46667 (HEAD -> master)
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Fri Apr 7 10:33:40 2017 +0100

    gst-plugins-base.supp: add gl suppressions for one off init allocations
    
    Add to valgrind suppressions file.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=781021