GNOME Bugzilla – Bug 78102
Keyboard shortcuts capplet should be integrated into the keyboard capplet
Last modified: 2010-11-18 18:34:41 UTC
The keyboard shortcuts capplet is pretty small. There really is no point in it being it's own independent capplet, it should be integrated into the main keyboard applet either as a new tab, or in the keyboard tab itself
Updating all cc bugs that have the GNOME2 keyword set to the GNOME2.0 milestone, to help jrb triage/prioritize cc bugs. Filter on 'luis doing GNOME2 work' to ignore this spam.
I like this idea.
Im going to cc usability maint, cuz i, of course, still like this idea and would like their opinions. Also why is this needinfo? I get kind of concerned i guess when bugs are needinfo, since i worry they may fall off people's radar.
Hmm, I guess that might work, especially if we removed the single-option Sound tab from the keypboard prefs dialog, and just put that option on the Keyboard tab. (Need a better name for the Keyboard tab though!) I haven't seen how big the keyboard shortcuts window has become since Erwann added the new 'assign a shortcut to any command' feature, though.
reopening to keep it on my radar, i hope this is ok jody???
SPAM as discussed last night. Search for 'SPAM as discussed last night' to catch these all and delete them. :)
Usability: given that the keyboard shortcuts dialog is now quite large, is this bug still valid?
I still quite like the idea of the merge, if we could make the shortcuts dialog narrower... it does seem to be wider than it needs to be right now. I can't remember how many times I've opened the Keyboard capplet when I really meant to open the Shortcuts one... but maybe that just means the Keyboard Shortcuts window should be renamed Shortcuts so the darn things aren't beside each other on the menu :)
I'm still in favor of a merger too, especially considering the need for additional capplets in the near future.
Any progress on this ?
We would still be under 5 tabs, I think it would be a good idea. Rename the existing keyboard preferences "keyboard" tab to "Speed settings" as they all have to do with speed and delays. We should keep the width of the keyboard shortcuts though and widen the others. I suggest this specifically because the Layout options already has a horizontal scrollbar by default on the right hand side. Widening it might help alleviate that situation I hope. Thus we could kill a horiz scroll, and consolidate 2 capplets into 1. In my opinion, that is a usability double whammy begging to happen!
Created attachment 108218 [details] [review] Proof-of-concept patch Attached patch creates a new tab in gnome-keyboard-preferences for the keybindings. This looks like a really huge patch but very very little is actually new, literally 99% is just copied from capplets/keybindings to capplets/keyboard. The major changes are: * Copied relevant parts of keybindings/gnome-keybinding-properties.glade into keyboard/gnome-keyboard-properties.glade * Opened and then saved keyboard/gnome-keyboard-properties.glade in Glade 3 to fix indentation. I think this might have rearranged some other elements that I didn't intend to modify. * Copied keybindings/gnome-keybinding-properties.c to keyboard/gnome-keybinding-properties.c, and made some minor changes so that it fits in with the keyboard dialog. This is a proof-of-concept-patch, so the stand-alone keybindings capplet, etc, has not been removed.
Created attachment 108219 [details] screenshot of new UI
The idea to merge keyboard and keybindings was discussed a bit during the last cycle when keyboard and keyboard a11y were pulled together. It wasn't pursued further then, although I don't remember the reasons at that time. Maybe there's something in the mailing list archive. So, in any case, you should restart that discussion by sending a mail with a pointer to this bug to the gnome-cc mailing list. Some comments on the patch in case the discussion results in a decision to proceed (just from looking at the screenshots and your description; didn't actually look at the patch itself, yet): * the shortcuts tab shouldn't be the last one since it's more important than some other settings in there * automerging the glade file with glade-3 is a big no-no. Doing that often results in subtle bugs and bugzilla has a number of crashers and similar issues caused by it. A minimal glade patch (possibly without reindentation) is mandatory for review. It might be reindented after review using whatever tool you like (but *only* for indentation purposes, so that excludes glade-3).
Cheers for the fast reply. :) (In reply to comment #14) > The idea to merge keyboard and keybindings was discussed a bit during the last > cycle when keyboard and keyboard a11y were pulled together. It wasn't pursued > further then, although I don't remember the reasons at that time. Maybe there's > something in the mailing list archive. So, in any case, you should restart that > discussion by sending a mail with a pointer to this bug to the gnome-cc mailing > list. > > Some comments on the patch in case the discussion results in a decision to > proceed (just from looking at the screenshots and your description; didn't > actually look at the patch itself, yet): > > * the shortcuts tab shouldn't be the last one since it's more important than > some other settings in there I agree, just thought I would keep it simple for the first patch and defer the decision of which position is correct. I would say it would probably be best between Layouts and Accessibility. > > * automerging the glade file with glade-3 is a big no-no. Doing that often > results in subtle bugs and bugzilla has a number of crashers and similar issues > caused by it. A minimal glade patch (possibly without reindentation) is > mandatory for review. It might be reindented after review using whatever tool > you like (but *only* for indentation purposes, so that excludes glade-3). > I merged by copying and pasting in text editor, I'm not sure what 'automerging' is. The glade-3 changes were accidental but I decided to leave it like that. I'll make a new patch with the glade changes made more clear.
Created attachment 108226 [details] [review] Fixed problems mentioned in comment 14 * Shortcuts tab moved to between Layouts and Accessibility * Removed whitespace changes to gnome-keybinding-properties.glade (whoops, that was not meant to be in there...) * Updated gnome-keyboard-properties.glade to make changes more obvious * Fixed duplicate id's in gnome-keyboard-properties.glade ( checked using grep -o "id=\".*\"" gnome-keyboard-properties.glade | uniq -d ) Is there a particular naming system for the widget id's (e.g. vbox61, etc)? For the ones that needed to be changed, I just used an arbitrary number.
Let's get this into 2.24, it's 6 years old and not so hard to fix - patch provided.
The bug was discussed on the mailing list [1] with fairly limited interest from the maintainers. So I imagine this probably won't be fixed anytime soon. Also the patch needs some work, it's really not reviewable as is. If the maintainers are interested I can fix it up. [1] http://mail.gnome.org/archives/gnomecc-list/2008-March/msg00018.html
Oh, that's bad, someone should take a decision quickly. Anyway here's two years old blogpost about that: http://blogs.gnome.org/rodrigo/2006/08/22/keyboard-control-center-applet/ and
That was done for GNOME 3.