After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780980 - gnome-music crashes on startup
gnome-music crashes on startup
Status: RESOLVED OBSOLETE
Product: gnome-music
Classification: Applications
Component: general
3.24.x
Other Linux
: Low minor
: ---
Assigned To: gnome-music-maint
gnome-music-maint
: 781209 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-04-06 15:53 UTC by Sebastian Keller
Modified: 2018-01-10 15:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Traceback (270 bytes, text/plain)
2017-04-06 15:53 UTC, Sebastian Keller
  Details
albumartcache: Check if tags is None (1.15 KB, patch)
2017-04-10 21:51 UTC, Marinus Schraal
committed Details | Review

Description Sebastian Keller 2017-04-06 15:53:34 UTC
Created attachment 349388 [details]
Traceback

Music crashes here (Fedora 26) on startup when loading the album art. The bug seems to have been introduced in 3.23.92 with this commit:
https://git.gnome.org/browse/gnome-music/commit/?id=38320cd8176a508c7f3ccf57b18c45fbba7b66b8

I think checking "tags" for "None" here in addition to the "error" check should fix the issue:
https://git.gnome.org/browse/gnome-music/tree/gnomemusic/albumartcache.py#n323

I've not tried this yet though and I'm not sure if this bug might not just be the result of a bug somewhere else in the stack.
Comment 1 Marinus Schraal 2017-04-06 16:41:06 UTC
This is a known issue and is some weird problem with the gstreamer interaction with some files/setups: tags is not supposed to be None.

For we probably should add the workaround you suggest, it was tested and is known to work.
Comment 2 Marinus Schraal 2017-04-10 21:51:32 UTC
Created attachment 349630 [details] [review]
albumartcache: Check if tags is None

Workaround for the issue where get_tags returns None. According to the
API this shouldn't happen, but reports indicate otherwise resulting in
crashes.
Comment 3 Marinus Schraal 2017-04-10 21:53:47 UTC
Comment on attachment 349630 [details] [review]
albumartcache: Check if tags is None

Pushed this as workaround for now, please test and confirm it at 
least avoids the crashing.

We still need to figure out what is going on here, so keeping the bug 
open.
Attachment 349630 [details] pushed as 4bd1aaf - albumartcache: Check if tags is None
Comment 4 Marinus Schraal 2017-04-12 14:50:57 UTC
*** Bug 781209 has been marked as a duplicate of this bug. ***
Comment 5 GNOME Infrastructure Team 2018-01-10 15:04:13 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-music/issues/105.