After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780955 - encode: Query the driver support for multi-slice encode before enabling it
encode: Query the driver support for multi-slice encode before enabling it
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
unspecified
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 780881
 
 
Reported: 2017-04-05 22:41 UTC by sreerenj
Modified: 2017-05-22 07:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libs: encoder: check for maximum number of slices (3.84 KB, patch)
2017-05-15 16:42 UTC, Víctor Manuel Jáquez Leal 		none Details | Review
libs: encoder: check for maximum number of slices (5.09 KB, patch)
2017-05-19 14:35 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description sreerenj 2017-04-05 22:41:14 UTC 
We use property num-slices to enable multi-slice encode.

We should query the driver support before enabling it by using VAConfigAttribEncMaxSlices.

driver patch: https://github.com/01org/intel-vaapi-driver/pull/118/commits/2c710d17ff0c152e076a47e743a1a38cd4095a27
Comment 1 Víctor Manuel Jáquez Leal 2017-05-15 16:42:46 UTC 
Created attachment 351902 [details] [review]
libs: encoder: check for maximum number of slices

Right now, H264 and HEVC can set as a property the number of slices to
process. But each driver can set a maximum number of slices, depending
on the supported profile & entry point.

This patch verifies the current num_slices to process against the maximum
permitted by the driver and the media size.
Comment 2 Víctor Manuel Jáquez Leal 2017-05-19 14:35:22 UTC 
Created attachment 352161 [details] [review]
libs: encoder: check for maximum number of slices

Right now, H264 and HEVC can set as a property the number of slices to
process. But each driver can set a maximum number of slices, depending
on the supported profile & entry point.

This patch verifies the current num_slices to process against the maximum
permitted by the driver and the media size.
Comment 3 Víctor Manuel Jáquez Leal 2017-05-19 15:06:08 UTC 
Attachment 352161 [details] pushed as ed3360b - libs: encoder: check for maximum number of slices