After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780954 - Transit routing get stuck when walking route search fails
Transit routing get stuck when walking route search fails
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-04-05 20:45 UTC by Marcus Lundblad
Modified: 2017-05-29 19:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
openTripPlanner: Approximate walking routes when not found (4.74 KB, patch)
2017-04-27 19:28 UTC, Marcus Lundblad
committed Details | Review

Description Marcus Lundblad 2017-04-05 20:45:47 UTC
In some rare circumstances, looking up transit stops can fail when no walking route is found, this can be seen i.e. if running OTP with the Swedish data and doing a route search to/from the place Sjisjka. This is located far out in road-less land along Malmbanan (and the OSM mapping lacks walking paths and stuff in this area), so GraphHopper is unable to find an exact walking route (the code in openTripPlanner.js does such a search for stops that are more than 100 m from the search location in an "as the crow flies manner"). I'm not 100% sure of the best solution here, either just bail out and use the straight-line distance in these cases, or fail the routing request.
Comment 1 Marcus Lundblad 2017-04-27 19:28:53 UTC
Created attachment 350590 [details] [review]
openTripPlanner: Approximate walking routes when not found

When GraphHopper fails to obtain a walking route, approximate it
with a straight line rather than bailing out trying to access a
null object. This can happen when starting off near a transit
stop in location with scarse OSM walking path coverage.
Comment 2 Marcus Lundblad 2017-05-29 19:46:39 UTC
Attachment 350590 [details] pushed as 9498af9 - openTripPlanner: Approximate walking routes when not found