GNOME Bugzilla – Bug 780945
GstPushSrc.do_create and Gst.BaseSrc.do_query are not introspected properly in bindings (Python)
Last modified: 2018-11-03 12:40:23 UTC
Created attachment 349314 [details] [review] Add annotations to vfuncs in base sources For example, When you use "do_create" vfunc in Python for a GstBaseSrc, you need to define the following method: def do_create(self, buff): # Implementation here But what you actually should do is def do_create(self): # Implementation here return buff I am uploading a patch that fixes that. PD: I also think that all vfuncs should be annotated.
Review of attachment 349314 [details] [review]: That's interesting. Is that a new GI feature ? If so, which version is required ? Problem though is that you are duplicating some doc, so I'd say if we go that route, we should move all the doc to use comment blocks.
(In reply to Nicolas Dufresne (stormer) from comment #1) > Review of attachment 349314 [details] [review] [review]: > > That's interesting. Is that a new GI feature ? If so, which version is > required ? Problem though is that you are duplicating some doc, so I'd say > if we go that route, we should move all the doc to use comment blocks. What are you talking about? These are normal GI annotations :) (In reply to César Fabián Orccón Chipana from comment #0) > > PD: I also think that all vfuncs should be annotated. Why do they all need to be annoted? There should be default handling like for other functions, and what you added as annotations here should be the default for these vfuncs. This looks like something broken in GI.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/227.