After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780944 - Please add a specific CSS class for appmenu button in GtkHeaderBar
Please add a specific CSS class for appmenu button in GtkHeaderBar
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-04-05 17:36 UTC by Dmitry Shachnev
Modified: 2017-04-06 12:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkheaderbar: add style classes to all title buttons (1.82 KB, patch)
2017-04-06 08:24 UTC, Alberts Muktupāvels 		accepted-commit_now Details | Review

Description Dmitry Shachnev 2017-04-05 17:36:33 UTC 
Currently close, minimize, maximize buttons have their own CSS classes (implemented in bug 744400).

It would be nice to have a specific CSS class for the appmenu button as well.

For example, in ubuntu-themes, close, minimize and maximize buttons are little circles, but the appmenu button may be larger and with lesser border-radius.
Comment 1 Matthias Clasen 2017-04-06 00:11:34 UTC 
makes sense to me
Comment 2 Alberts Muktupāvels 2017-04-06 08:24:01 UTC 
Created attachment 349345 [details] [review]
gtkheaderbar: add style classes to all title buttons

Commit b187773053098cca1b7c23e04e096d47fbb65a5f added CSS style
classes for minimize, maximize and close buttons. Add similar classes
also to icon and menu buttons.
Comment 3 Matthias Clasen 2017-04-06 12:20:26 UTC 
Review of attachment 349345 [details] [review]:

looks good to me. should probably go into 3.22 as well
Comment 4 Alberts Muktupāvels 2017-04-06 12:24:19 UTC 
I guess it is not that simple...

At least Adwaita has css for .menu, would not that affect button? :(
Comment 5 Dmitry Shachnev 2017-04-06 12:27:37 UTC 
Can you change the class to “appmenu”? This way it would be also consistent with the button name in gsettings.
Comment 6 Alberts Muktupāvels 2017-04-06 12:38:43 UTC 
Pushed to master and gtk-3-22 branches. Menu button css class was changed from `menu` to `appmenu`.