GNOME Bugzilla – Bug 780915
Tweak Tool Dark Theme switch should enable dark theme for gtk-4.0 too
Last modified: 2017-05-30 11:20:46 UTC
For the Global Dark Theme toggle switch, Tweak Tool checks and sets the gtk-application-prefer-dark-theme key in ~/.config/gtk-3.0/settings.ini I propose that it still check the key there, but when the switch is turned on, it should enable that key and the same key in ~/.config/gtk-4.0/settings.ini
To test this: 1. Install gtk4 2. Turn on Global Dark Theme in Tweak Tool 3. Run gtk4-demo and see if the interface is light gray or dark gray.
See also bug 770607 for gtk2
Created attachment 352832 [details] [review] widgets: Enable Dark Theme for gtk4 too What's a singleton? All I know is that I eventually guessed that that line was what was keeping my code from working. Passing the version number is important because if we tried to set an unsupported gtksetting (like dark-theme for gtk2), we'd get a console warning when starting an app using that version of gtk. I don't see any gtk2 settings we care about now, but maybe there will be something new in gtk4 that we'll want eventually.
Review of attachment 352832 [details] [review]: looks fine, thanks
Attachment 352832 [details] pushed as 62c0f53 - widgets: Enable Dark Theme for gtk4 too