After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780915 - Tweak Tool Dark Theme switch should enable dark theme for gtk-4.0 too
Tweak Tool Dark Theme switch should enable dark theme for gtk-4.0 too
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-04-05 01:02 UTC by Jeremy Bicha
Modified: 2017-05-30 11:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
widgets: Enable Dark Theme for gtk4 too (2.32 KB, patch)
2017-05-29 22:58 UTC, Jeremy Bicha
committed Details | Review

Description Jeremy Bicha 2017-04-05 01:02:05 UTC
For the Global Dark Theme toggle switch, Tweak Tool checks and sets the gtk-application-prefer-dark-theme key in ~/.config/gtk-3.0/settings.ini

I propose that it still check the key there, but when the switch is turned on, it should enable that key and the same key in ~/.config/gtk-4.0/settings.ini
Comment 1 Jeremy Bicha 2017-04-05 01:03:50 UTC
To test this:

1. Install gtk4
2. Turn on Global Dark Theme in Tweak Tool
3. Run gtk4-demo and see if the interface is light gray or dark gray.
Comment 2 Jeremy Bicha 2017-04-05 01:04:16 UTC
See also bug 770607 for gtk2
Comment 3 Jeremy Bicha 2017-05-29 22:58:31 UTC
Created attachment 352832 [details] [review]
widgets: Enable Dark Theme for gtk4 too

What's a singleton? All I know is that I eventually guessed that that line was what was keeping my code from working.

Passing the version number is important because if we tried to set an unsupported gtksetting (like dark-theme for gtk2), we'd get a console warning when starting an app using that version of gtk.

I don't see any gtk2 settings we care about now, but maybe there will be something new in gtk4 that we'll want eventually.
Comment 4 Rui Matos 2017-05-30 10:01:01 UTC
Review of attachment 352832 [details] [review]:

looks fine, thanks
Comment 5 Jeremy Bicha 2017-05-30 11:20:43 UTC
Attachment 352832 [details] pushed as 62c0f53 - widgets: Enable Dark Theme for gtk4 too