After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780862 - autotools: Use AM_DISTCHECK_CONFIGURE_FLAGS
autotools: Use AM_DISTCHECK_CONFIGURE_FLAGS
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-03 08:43 UTC by Mario Sánchez Prada
Modified: 2017-04-03 14:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch proposal attached (from Sam Spilsbury) (1.23 KB, patch)
2017-04-03 08:45 UTC, Mario Sánchez Prada 		none Details | Review
Patch proposal attached (from Sam Spilsbury) (1.21 KB, patch)
2017-04-03 10:51 UTC, Mario Sánchez Prada 		committed Details | Review

Description Mario Sánchez Prada 2017-04-03 08:43:02 UTC 
Since automake 1.11.2 it is recommended that packages use AM_DISTCHECK_CONFIGURE_FLAGS instead of DISTCHECK_CONFIGURE_FLAGS as the latter is intended to be a user variable.

We had this in endless for a while already, it's probably a good idea to apply it upstream now. See https://github.com/endlessm/gdm/commit/83bf7e9773ca79dcd9b42472a47a6f84e87ac319#diff-67e997bcfdac55191033d57a16d1408a
Comment 1 Mario Sánchez Prada 2017-04-03 08:45:31 UTC 
Created attachment 349160 [details] [review]
Patch proposal attached (from Sam Spilsbury)
Comment 2 Mario Sánchez Prada 2017-04-03 10:50:17 UTC 
Comment on attachment 349160 [details] [review]
Patch proposal attached (from Sam Spilsbury)

>From b89e0beaf4e59bb7ee988a210e2e952d8f6bc115 Mon Sep 17 00:00:00 2001
>From: Sam Spilsbury <smspillaz@gmail.com>
>Date: Tue, 21 Jul 2015 08:14:59 +0800
>Subject: [PATCH] Makefile: Move to AM_DISTCHECK_CONFIGURE_FLAGS
>
>Since automake 1.11.2 it is recommended that packages
>use AM_DISTCHECK_CONFIGURE_FLAGS instead of
>DISTCHECK_CONFIGURE_FLAGS as the latter is intended
>to be a user variable.
>---
> Makefile.am  | 2 +-
> configure.ac | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Makefile.am b/Makefile.am
>index fa3bdcc..d3c46c8 100644
>--- a/Makefile.am
>+++ b/Makefile.am
>@@ -30,4 +30,4 @@ EXTRA_DIST = \
> DISTCLEANFILES = \
> 	$(NULL)
> 
>-DISTCHECK_CONFIGURE_FLAGS = --enable-split-authentication --enable-introspection
>+AM_DISTCHECK_CONFIGURE_FLAGS = --enable-split-authentication --enable-introspection
>diff --git a/configure.ac b/configure.ac
>index 060816d..d9a5b5c 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -6,7 +6,7 @@ AC_INIT([gdm],
> 
> AC_CONFIG_SRCDIR([daemon/gdm-manager.c])
> 
>-AM_INIT_AUTOMAKE([1.10 no-dist-gzip dist-xz tar-ustar -Wall])
>+AM_INIT_AUTOMAKE([1.11.2 no-dist-gzip dist-xz tar-ustar -Wall])
> m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
> AM_MAINTAINER_MODE([enable])
> 
>-- 
>2.9.3
>
Comment 3 Mario Sánchez Prada 2017-04-03 10:51:21 UTC 
Created attachment 349170 [details] [review]
Patch proposal attached (from Sam Spilsbury)

Please ignore the previous comment (and sorry for the spam).
Comment 4 Ray Strode [halfline] 2017-04-03 14:12:10 UTC 
Review of attachment 349170 [details] [review]:

sure!
Comment 5 Mario Sánchez Prada 2017-04-03 14:30:22 UTC 
Thanks, fixed in master:
https://git.gnome.org/browse/gdm/commit/?id=8918b0b52c0848be5a4f9f17a5b634a99da3c8f6