GNOME Bugzilla – Bug 780851
[PATCH] Add bookmark followed by remove bookmark causes crash
Last modified: 2017-04-02 19:10:53 UTC
Due to the fact that a bookmark is added to the manager when the popover is closed, a press on the bookmark button followed by a press on the "Remove bookmark" button causes a crash because ephy_bookmarks_manager_remove_bookmark() tries to find the new bookmark which has not been added yet.
Created attachment 349146 [details] [review] add-bookmark-popover: Save bookmarks on both popover show and close Due to the fact that a bookmark is added to the manager when the popover is closed, a press on the bookmark button followed by a press on the "Remove bookmark" button causes a crash because ephy_bookmarks_manager_remove_bookmark() tries to find the new bookmark which has not been added yet. Revert to the original behaviour where a bookmark is saved immediately after pressing the star, but also save the bookmark when the popover is closed in case the user changed something while the popover was open
Whatever you do to fix this is going to cause some new crash somewhere else. :( The solution to this is automated testing, but no chance of that happening anytime soon. Shame.
Review of attachment 349146 [details] [review]: OK
Attachment 349146 [details] pushed as 22bdf16 - add-bookmark-popover: Save bookmarks on both popover show and close