After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780847 - File auto-saved twice
File auto-saved twice
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: libide
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-02 16:17 UTC by Gennady Kovalev
Modified: 2017-04-02 21:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch called unregister auto-save on buffer save (1.13 KB, patch)
2017-04-02 20:51 UTC, Gennady Kovalev 		accepted-commit_now Details | Review

Description Gennady Kovalev 2017-04-02 16:17:02 UTC 
Then I edit file it automatically saved twice.

Log of my experiments:

18:36 Open file, edit, do not save
18:37 *Auto-save
18:38 *Auto-save
18:40 Edit, do not save
18:41 *Auto-save
18:42 *Auto-save
18:43 Edit, do not save
18:44 *Auto-save
18:46 Edit, do not save
18:47 *Auto-save
18:48 *Auto-save
18:50 Edit, do not save
18:51 *Auto-save

18:54 Edit,save manually
18:54 *Saved manually
18:55 *Auto-save
18:58 Edit & save
18:58 *Saved manually
18:59 *Auto-save
19:01 Edit & save
19:01 *Saved manually
19:02 *Auto-save
Comment 1 Gennady Kovalev 2017-04-02 19:05:30 UTC 
I add g_debug() to register_auto_save(), ide_buffer_manager_auto_save_cb() and unregister_auto_save(). 

When I use Ctrl+S and "Save" menu item method unregister_auto_save() not called. After timeout file saved, called ide_buffer_manager_auto_save_cb() and only then called unregister_auto_save().
Comment 2 Gennady Kovalev 2017-04-02 20:51:18 UTC 
Created attachment 349149 [details] [review]
Patch called unregister auto-save on buffer save
Comment 3 Christian Hergert 2017-04-02 21:07:03 UTC 
Review of attachment 349149 [details] [review]:

LGTM, thanks for tracking this down!
Comment 4 sébastien lafargue 2017-04-02 21:31:07 UTC 
committed as dd11bc6

This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.