After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780838 - Media selector's state between display header bars is not in sync
Media selector's state between display header bars is not in sync
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-02 10:38 UTC by Abhinav Singh
Modified: 2018-08-17 08:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui: Update MediaSelector on media number update (1.01 KB, patch)
2017-07-08 07:08 UTC, Abhinav Singh 		none Details | Review
ui: Update MediaSelector on media number update (1.31 KB, patch)
2017-12-15 16:52 UTC, Abhinav Singh 		none Details | Review

Description Abhinav Singh 2017-04-02 10:38:15 UTC 
How to reproduce:

* Run a multidisc game
* Click media > change the disc
* Go to fullscreen mode
* Click media

The disc in this media selector is not updated.
Comment 1 Abhinav Singh 2017-07-08 07:08:56 UTC 
Created attachment 355141 [details] [review]
ui: Update MediaSelector on media number update

This syncs the MediaSelectors in both normal header bar and full screen
header bar.
Comment 2 Adrien Plazas 2017-12-01 06:26:50 UTC 
Review of attachment 355141 [details] [review]:

Thanks! It's almost good, just a small thing to fix and it will be perfect.

::: src/ui/media-selector.vala
@@ +7,3 @@
 		set {
 			_media_set = value;
+			_media_set.notify["selected-media-number"].connect (reset_media);

You need to disconnect any previous connection, to do so you need to store the ID return by this line and use it in `_media_set.disconnect (your_id_here)`.
Comment 3 Abhinav Singh 2017-12-15 16:52:31 UTC 
Created attachment 365600 [details] [review]
ui: Update MediaSelector on media number update

This syncs the MediaSelectors in both normal header bar and full screen
header bar.