Created attachment 349101 [details] [review]
Multiqueue: don't allow dropping SEGMENT_DONE events

Review of attachment 349101 [details] [review]:

Patch seems to make sense but I'm curious on why this happens? Downstream is returning EOS in the end of a segment?

Also, isn't it more readable and faster just to set the variable to false instead of doing the if before setting?

Created attachment 349133 [details] [review]
Multiqueue: don't allow dropping SEGMENT_DONE events

(In reply to Thiago Sousa Santos from comment #2)
> Review of attachment 349101 [details] [review] [review]:
> 
> Patch seems to make sense but I'm curious on why this happens? Downstream is
> returning EOS in the end of a segment?

Yes, that is exactly what happens, the decoders returns EOS.

> 
> Also, isn't it more readable and faster just to set the variable to false
> instead of doing the if before setting?

Yep, just copy pasted what the GST_EVENT_EOS case was doing, but there's indeed no point in that if, fixed.

Thanks for the review!

Review of attachment 349133 [details] [review]:

Feel free to also remove the if from the EOS case, seems useless as well.

Created attachment 355106 [details] [review]
Multiqueue: don't allow dropping SEGMENT_DONE events

Erg I'm sorry, I had updated that patch locally but forgot to resubmit it, I've attached the updated version.

Attachment 355106 [details] pushed as 053f152 - Multiqueue: don't allow dropping SEGMENT_DONE events