After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780779 - Port to GTask
Port to GTask
Status: RESOLVED OBSOLETE
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-31 18:06 UTC by Debarshi Ray
Modified: 2021-07-05 11:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
documents: Prepare for future exceptions (2.03 KB, patch)
2017-03-31 18:36 UTC, Debarshi Ray 		committed Details | Review
utils: Port gd_queue_thumbnail_job_for_file_async to GTask (4.87 KB, patch)
2017-03-31 18:37 UTC, Debarshi Ray 		none Details | Review
utils: Port gd_queue_thumbnail_job_for_file_async to GTask (4.74 KB, patch)
2017-04-04 14:46 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-03-31 18:06:48 UTC 
GSimpleAsyncResult and GIOScheduler usage has now started throwing deprecation warnings. We have quite a few of them, enough to make the build too noisy to detect actual problems.

Let's port to GTask.
Comment 1 Debarshi Ray 2017-03-31 18:36:51 UTC 
Created attachment 349074 [details] [review]
documents: Prepare for future exceptions
Comment 2 Debarshi Ray 2017-03-31 18:37:03 UTC 
Created attachment 349075 [details] [review]
utils: Port gd_queue_thumbnail_job_for_file_async to GTask
Comment 3 Cosimo Cecchi 2017-03-31 19:44:15 UTC 
Review of attachment 349074 [details] [review]:

OK
Comment 4 Cosimo Cecchi 2017-03-31 19:48:09 UTC 
Review of attachment 349075 [details] [review]:

Just a couple of minor comments.

::: src/lib/gd-utils.c
@@ +44,2 @@
   GnomeDesktopThumbnailFactory *factory = NULL;
+  GError *error;

Initialize the error here.

@@ +74,3 @@
+                               g_quark_from_static_string ("gnome-desktop-error"),
+                               0,
+                               "GnomeDesktopThumbnailFactory failed");

I'd just report a generic G_IO_ERROR_FAILED here, instead of using a new atom (i.e. we should not pretend to be gnome-desktop).
Comment 5 Debarshi Ray 2017-04-04 14:46:28 UTC 
Created attachment 349242 [details] [review]
utils: Port gd_queue_thumbnail_job_for_file_async to GTask
Comment 6 Cosimo Cecchi 2017-04-04 16:26:48 UTC 
Review of attachment 349242 [details] [review]:

Looks good.
Comment 7 GNOME Infrastructure Team 2021-07-05 11:30:59 UTC 
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/gnome-documents/-/issues/

Thank you for your understanding and your help.