After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780770 - filesink: Add new "list" buffering mode
filesink: Add new "list" buffering mode
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-31 15:42 UTC by Vivia Nikolaidou
Modified: 2017-05-16 11:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
filesink: Add new "list" buffering mode (6.08 KB, patch)
2017-03-31 15:42 UTC, Vivia Nikolaidou 		rejected Details | Review

Description Vivia Nikolaidou 2017-03-31 15:42:03 UTC 
See commit message
Comment 1 Vivia Nikolaidou 2017-03-31 15:42:06 UTC 
Created attachment 349062 [details] [review]
filesink: Add new "list" buffering mode

In some high-load scenarios (e.g. 2x4k60p) it's better to reduce the
number of vwrite() calls, rather than having more calls with kernel-side
buffering. The "list" buffering mode keeps the buffers in a
GstBufferList until they reach the buffer-size threshold.
Comment 2 Olivier Crête 2017-03-31 19:16:54 UTC 
Wouldnt it make more sense to create the lists upstream ? maybe by having the muxer use bigger buffers or create bufferlists? A lot of the CPU overhead of gst is per-buffer.
Comment 3 Sebastian Dröge (slomo) 2017-05-16 11:58:05 UTC 
According to Vivia, the patch is broken and not needed anymore. It's solved differently now on their side.