After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780752 - Moved resources to data directory
Moved resources to data directory
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-31 10:32 UTC by Iñigo Martínez
Modified: 2017-11-08 00:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Moved resources to data directory (6.78 KB, patch)
2017-03-31 10:32 UTC, Iñigo Martínez 		none Details | Review
Move resources to data directory (4.17 KB, patch)
2017-10-26 06:09 UTC, Iñigo Martínez 		committed Details | Review

Description Iñigo Martínez 2017-03-31 10:32:56 UTC 
Created attachment 349035 [details] [review]
Moved resources to data directory

Moved resource description file and the resources to the data directory as other gnome applications do. The file has been moved to the theme directory and UI definition files to the ui directory.

Resource compilation has been improved also by adding a check into configure step to set GLIB_COMPILE_RESOURCES variable to be used on resource compilation.
Comment 1 Isaque Galdino 2017-10-25 09:56:06 UTC 
Can you please update this patch?
Thanks.
Comment 2 Iñigo Martínez 2017-10-26 06:09:56 UTC 
Created attachment 362306 [details] [review]
Move resources to data directory

(In reply to Isaque Galdino from comment #1)
> Can you please update this patch?
> Thanks.

Sure! The idea behind this patch is to move resources to the place they belong, this is `data` directory used for non-source code/data files. It also helps isolating all the source code into `src` directory.
Comment 3 Isaque Galdino 2017-11-08 00:42:11 UTC 
Review of attachment 362306 [details] [review]:

Thanks for your patch. I've reviewed it and I added a missing resource file: empty-results-box.ui.