After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780735 - flowbox: don’t select when rubberbanding over nothing
flowbox: don’t select when rubberbanding over nothing
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-03-30 19:36 UTC by Ernestas Kulik
Modified: 2017-03-31 09:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flowbox: don’t select when rubberbanding over nothing (1.34 KB, patch)
2017-03-30 19:36 UTC, Ernestas Kulik 		committed Details | Review

Description Ernestas Kulik 2017-03-30 19:36:07 UTC 
When rubberbanding over an empty area, everything is selected on gesture
end, which is a bit counter-intuitive.
Comment 1 Ernestas Kulik 2017-03-30 19:36:13 UTC 
Created attachment 349014 [details] [review]
flowbox: don’t select when rubberbanding over nothing
Comment 2 Matthias Clasen 2017-03-30 21:22:21 UTC 
Review of attachment 349014 [details] [review]:

::: gtk/gtkflowbox.c
@@ +3149,1 @@
       gtk_flow_box_stop_rubberband (box);

We don't put {} in this case, in GTK+ code. Please remove them before pushing this
Comment 3 Ernestas Kulik 2017-03-31 04:25:32 UTC 
Attachment 349014 [details] pushed as fe1e53a - flowbox: don’t select when rubberbanding over nothing