GNOME Bugzilla – Bug 780731
Photos exits when handling unknown/unsupported file format
Last modified: 2018-01-23 10:12:21 UTC
gnome-photos-3.24.0-1.fc26.x86_64 We saw this after adding git-lfs support to https://github.com/hadess/gnome-demo-content The machine didn't have git-lfs installed, so we got text files in place of photos, in the Pictures directory Clicking on an unsupported photo simply exits with retval 1, not crash, no error message, simply exits. $ cat foo.jpg version https://git-lfs.github.com/spec/v1 oid sha256:9b1db5ff43b50d91a297da35bd816bf62f45d8a818bce44d1b76be367603c045 size 510986 $ tracker index --file foo.jpg $ gnome-photos ** (gnome-photos:8891): WARNING **: Unable to create thumbnail: GDBus.Error:org.gtk.GDBus.UnmappedGError.Quark._gdk_2dpixbuf_2derror_2dquark.Code3: Impossible de reconnaître le format d'image du fichier « /home/gnome/Images/foo.jpg » Not a JPEG file: starts with 0x76 0x65 $ echo $? 1
We need better ways to load a GeglBuffer from a file. We currently do so using the gegl:load operation but that has literally zero error handling.
> Clicking on an unsupported photo simply exits with retval 1, not crash, no > error message, simply exits. > Hi Bastien, can you test this again with the latest version or probably master and see if you can still reproduce this ? And if so, can you kindly attach the sample file/image on which you are noticing this behaviour? Thanks!
The status of this bug is unchanged. Note that this bug is not about a particular file, but about handling decoding errors. We are always going to have malformed files.
*** Bug 776669 has been marked as a duplicate of this bug. ***
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-photos/issues/63.