After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780718 - Use GnomeDesktop API to simplify code, etc..
Use GnomeDesktop API to simplify code, etc..
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-30 11:17 UTC by Debarshi Ray
Modified: 2017-03-31 05:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
documents: Use a global named constant for the OneDrive prefix (1.54 KB, patch)
2017-03-30 11:21 UTC, Debarshi Ray 		committed Details | Review
documents: Simplify calculation of thumbnail paths for GoogleDocuments (1.82 KB, patch)
2017-03-30 11:22 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-03-30 11:17:45 UTC 
The code to thumbnail GoogleDocuments can be simplified by exploiting GnomeDesktop API. We should also use a named constant for the indentifier prefix for SkydriveDocuments.
Comment 1 Debarshi Ray 2017-03-30 11:21:51 UTC 
Created attachment 348985 [details] [review]
documents: Use a global named constant for the OneDrive prefix
Comment 2 Debarshi Ray 2017-03-30 11:22:05 UTC 
Created attachment 348986 [details] [review]
documents: Simplify calculation of thumbnail paths for GoogleDocuments
Comment 3 Debarshi Ray 2017-03-30 11:22:42 UTC 
Getting some patches out of the way while hacking on bug 774937. I need to test them a more thoroughly.
Comment 4 Cosimo Cecchi 2017-03-30 16:00:43 UTC 
Review of attachment 348985 [details] [review]:

Sure
Comment 5 Cosimo Cecchi 2017-03-30 16:03:12 UTC 
Review of attachment 348986 [details] [review]:

Looks good.
Comment 6 Debarshi Ray 2017-03-31 05:26:33 UTC 
Thanks. Pushed to master.