After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780700 - notebook: make the class final
notebook: make the class final
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-29 18:53 UTC by Tiberiu Lepadatu
Modified: 2017-03-30 19:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
notebook: make the class final (2.91 KB, patch)
2017-03-29 18:53 UTC, Tiberiu Lepadatu 		none Details | Review
notebook: make the class final (2.91 KB, patch)
2017-03-29 21:03 UTC, Tiberiu Lepadatu 		committed Details | Review

Description Tiberiu Lepadatu 2017-03-29 18:53:52 UTC 
See patch.
Comment 1 Tiberiu Lepadatu 2017-03-29 18:53:57 UTC 
Created attachment 348948 [details] [review]
notebook: make the class final

The class NautilusNotebook is not extended by any other class so it
should be made final. Use the new type declarations to do so.
Comment 2 Tiberiu Lepadatu 2017-03-29 21:03:17 UTC 
Created attachment 348955 [details] [review]
notebook: make the class final

The class NautilusNotebook is not extended by any other class so it
should be made final. Use the new type declarations to do so.
Comment 3 Razvan Chitu 2017-03-29 21:08:07 UTC 
Review of attachment 348955 [details] [review]:

LGTM, thanks. Waiting for Ernestas / Carlos to take a look.
Comment 4 Ernestas Kulik 2017-03-30 17:45:28 UTC 
Review of attachment 348955 [details] [review]:

Looking fine, thanks, Tiberiu!
Comment 5 Razvan Chitu 2017-03-30 19:35:20 UTC 
Attachment 348955 [details] pushed as 0b30fe0 - notebook: make the class final