After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780697 - progress-info-manager: port away from manual decls
progress-info-manager: port away from manual decls
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-29 18:33 UTC by Horia Ion
Modified: 2017-03-30 19:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
progress-info-manager: port away from manual decls (7.95 KB, patch)
2017-03-29 18:33 UTC, Horia Ion 		none Details | Review
progress-info-manager: port away from manual decls (8.02 KB, patch)
2017-03-29 21:10 UTC, Horia Ion 		committed Details | Review

Description Horia Ion 2017-03-29 18:33:07 UTC 
This patch reduces the number of macros used to define the type,
by means of the macro G_DECLARE*, and improves the readability of code.
Comment 1 Horia Ion 2017-03-29 18:33:10 UTC 
Created attachment 348944 [details] [review]
progress-info-manager: port away from manual decls

This patch reduces the number of macros used to define the type,
by means of the macro G_DECLARE*, and improves the readability of code.
Comment 2 Razvan Chitu 2017-03-29 20:41:34 UTC 
Review of attachment 348944 [details] [review]:

Looks good besides the coding style issue, thanks!

::: src/nautilus-progress-info-manager.c
@@ +164,1 @@
                                                         l->data);

There's a misalignment here with the line above (probably because self->priv became self)
Comment 3 Horia Ion 2017-03-29 21:10:54 UTC 
Created attachment 348956 [details] [review]
progress-info-manager: port away from manual decls

This patch reduces the number of macros used to define the type,
by means of the macro G_DECLARE*, and improves the readability of code.
Comment 4 Razvan Chitu 2017-03-29 21:34:35 UTC 
Review of attachment 348956 [details] [review]:

Looks good, thanks! Waiting for Ernestas / Carlos to take a look.
Comment 5 Carlos Soriano 2017-03-30 07:04:27 UTC 
Review of attachment 348956 [details] [review]:

LGTM thanks!