After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780687 - word completion: Add user-defined minimum word size functionality
word completion: Add user-defined minimum word size functionality
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: preferences
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-29 15:37 UTC by Umang Jain
Modified: 2017-03-30 05:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Gedit's minimum word size (44.14 KB, image/png)
2017-03-29 15:37 UTC, Umang Jain 		  Details
preferences-editor: Add user-defined minimum word functionality (4.73 KB, patch)
2017-03-30 03:43 UTC, Umang Jain 		committed Details | Review

Description Umang Jain 2017-03-29 15:37:17 UTC 
Created attachment 348939 [details]
Gedit's minimum word size

In gedit, you can set the minimum word size for word complete functionality. It can be easily integrated in Builder as well. It simple but will take some thoughts for its UI design.

Attaching gedit's screenshot for reference
Comment 1 Christian Hergert 2017-03-29 17:06:31 UTC 
This should be a fairly straightforward addition to libide/preferences/ide-preferences-builtins.c (and associated GSetting in data/gsettings).

The relative code to change is in libide/buffers/ide-buffer-manager.c:1552 where it creates the IdeCompletionWords. It will need a GSettings binding for the same key that goes into preferences.
Comment 2 Umang Jain 2017-03-30 03:43:15 UTC 
Created attachment 348968 [details] [review]
preferences-editor: Add user-defined minimum word  functionality
Comment 3 Christian Hergert 2017-03-30 05:22:00 UTC 
Review of attachment 348968 [details] [review]:

LGTM, excellent work!
Comment 4 Christian Hergert 2017-03-30 05:42:15 UTC 
Pushed with a small change to put the preference near the "enable word completion" switch.