After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780678 - Don't show TODOs from .flatpak-builder
Don't show TODOs from .flatpak-builder
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
Flatpak Nightly Channel
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-29 10:58 UTC by Adrien Plazas
Modified: 2017-03-29 18:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
todo: Ignore .flatpak-builder/ and .git/ (1.21 KB, patch)
2017-03-29 14:51 UTC, Matthew Leeds 		accepted-commit_now Details | Review

Description Adrien Plazas 2017-03-29 10:58:18 UTC 
When building an application with Flatpak, the Todo tab is filed with todos from the .flatpak-builder/cache/objects directory that I don't want to see.
Comment 1 Adrien Plazas 2017-03-29 13:28:21 UTC 
Mmmh… adding .flatpak-builder to .gitignore does the trick. Maybe we don't need to make a special case just for it.
Comment 2 Matthew Leeds 2017-03-29 14:51:37 UTC 
Created attachment 348938 [details] [review]
todo: Ignore .flatpak-builder/ and .git/

Don't grep inside .flatpak-builder/ or .git/ when looking for TODO
comments as it's a waste of resources and not what the user wants. If
the user puts .flatpak-builder in their .gitignore the results will be
ignored anyway but at least this way we don't waste the effort.
Comment 3 Christian Hergert 2017-03-29 17:07:50 UTC 
Review of attachment 348938 [details] [review]:

Oh interesting, I had this on a branch and forgot to merge to master. Go ahead and push this.
Comment 4 Christian Hergert 2017-03-29 17:08:29 UTC 
(Seems fine to push this to gnome-builder-3-24 too)
Comment 5 Matthew Leeds 2017-03-29 18:01:19 UTC 
Pushed as commit 2d03f33ca95523a50f9ce7ca7aa081fe70ce8d3e