After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780667 - gdk-pixbuf tarballs fail tests since 2.36.6 EXIF comments support
gdk-pixbuf tarballs fail tests since 2.36.6 EXIF comments support
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-28 22:10 UTC by Mart Raudsepp
Modified: 2017-07-28 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Fix EXIF comment test in dist tarballs (681 bytes, patch)
2017-03-28 22:18 UTC, Mart Raudsepp 		committed Details | Review

Description Mart Raudsepp 2017-03-28 22:10:42 UTC 
Bug 143608 added a new test file, but fails to EXTRA_DIST it, so make check from a tarball is broken. distcheck should theoretically be failing too and should have caught this..

ERROR: pixbuf-jpeg
==================

# random seed: R02S5cf6d40d07f03faaa74b7cd7f047d1e8
1..4
# Start of pixbuf tests
# Start of jpeg tests
**
ERROR:/tmp/portage/x11-libs/gdk-pixbuf-2.36.6/work/gdk-pixbuf-2.36.6/tests/pixbuf-jpeg.c:112:test_comment: assertion failed (error == NULL): Failed to open file '/tmp/portage/x11-libs/gdk-pixbuf-2.36.6/work/gdk-pixbuf-2.36.6/tests/bug143608-comment.jpg': No such file or directory (g-file-error-quark, 4)
ok 1 /pixbuf/jpeg/inverted_cmyk_jpeg
PASS: pixbuf-jpeg 1 /pixbuf/jpeg/inverted_cmyk_jpeg
ok 2 /pixbuf/jpeg/type9_rotation_exif_tag
PASS: pixbuf-jpeg 2 /pixbuf/jpeg/type9_rotation_exif_tag
ok 3 /pixbuf/jpeg/bug775218
PASS: pixbuf-jpeg 3 /pixbuf/jpeg/bug775218
Aborted (core dumped)
# ERROR:/tmp/portage/x11-libs/gdk-pixbuf-2.36.6/work/gdk-pixbuf-2.36.6/tests/pixbuf-jpeg.c:112:test_comment: assertion failed (error == NULL): Failed to open file '/tmp/portage/x11-libs/gdk-pixbuf-2.36.6/work/gdk-pixbuf-2.36.6/tests/bug143608-comment.jpg': No such file or directory (g-file-error-quark, 4)
ERROR: pixbuf-jpeg - too few tests run (expected 4, got 3)
ERROR: pixbuf-jpeg - exited with status 134 (terminated by signal 6?)
Comment 1 Mart Raudsepp 2017-03-28 22:18:28 UTC 
Created attachment 348910 [details] [review]
tests: Fix EXIF comment test in dist tarballs

Untested patch to get tarballs pass make check.
Haven't tested an actual tarball creation after this, but given the surroundings, this should work fine
Comment 2 Pawel Xj 2017-03-28 23:36:50 UTC 
hehe .. I wanted to use one of existing files when I created that code. IMHO one jpg file could be used in many tests ... but I has been force to made new file. That's how bureaucracy creates problems ;-)
Comment 3 Bastien Nocera 2017-07-28 15:58:30 UTC 
(In reply to Pawel Xj from comment #2)
> hehe .. I wanted to use one of existing files when I created that code. IMHO
> one jpg file could be used in many tests ... but I has been force to made
> new file. That's how bureaucracy creates problems ;-)

Not running all the tests creates problems...
Comment 4 Bastien Nocera 2017-07-28 15:59:29 UTC 
Attachment 348910 [details] pushed as 63c45b3 - tests: Fix EXIF comment test in dist tarballs