After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780637 - OSM edit dialog wiki links should use HTTPS
OSM edit dialog wiki links should use HTTPS
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-28 07:16 UTC by Marcus Lundblad
Modified: 2017-03-28 19:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
OSM edit dialog wiki links should use HTTPS (821 bytes, patch)
2017-03-28 13:27 UTC, Ludovico de Nittis 		committed Details | Review

Description Marcus Lundblad 2017-03-28 07:16:08 UTC 
In the OpenStreetMap edit dialog, editable fields can optionally show a link to the OpenStreetMap wiki about that feature. This link currently uses HTTP, but we should probably use HTTPS. The base URL used for constructing these links can be seen here: https://git.gnome.org/browse/gnome-maps/tree/src/osmEditDialog.js#n58
Fixing this should only be a matter of changing that base URL template to use https://
Comment 1 Ludovico de Nittis 2017-03-28 13:27:53 UTC 
Created attachment 348885 [details] [review]
OSM edit dialog wiki links should use HTTPS
Comment 2 Marcus Lundblad 2017-03-28 19:39:15 UTC 
Review of attachment 348885 [details] [review]:

LGTM
Comment 3 Marcus Lundblad 2017-03-28 19:43:27 UTC 
Thanks for the patch!
BTW, I edited the commit message slightly. So that the header line follows the "module: Short description of change" pattern.