GNOME Bugzilla – Bug 780634
Remove remaining old codepage ABI comapt code
Last modified: 2017-07-25 10:51:27 UTC
From what I see the ABI compat code was added more than 10 years ago, so removing it now should not affect anyone. desrt did a similar change 4 years ago: https://git.gnome.org/browse/glib/commit/?id=8c42a663f8182f8281c083390aa761e8e9badc63 * It removes quite a lot of code, defines and ifdefery * It should make the non-codepage functions available to bindings on Windows. The pygobject test suite currently fails because only the codepage symbols are accessible and only on 32bit. To summarize the change: Before: * new 32/64bit code linked against *_utf8 * on 32bit the code page functions where exposed as well under the normal name so old binaries link against that After: * new 32/64bit code links against normal names * old binaries will use the _utf8 variants which are equivalent * 15 year old binaries might break if non-ASCII is involved
Created attachment 348854 [details] [review] gconvert: Remove old win32 codepage ABI compat code
Created attachment 348855 [details] [review] gdir: Remove old win32 codepage ABI compat code
Created attachment 348856 [details] [review] genviron: Remove old win32 codepage ABI compat code
Created attachment 348857 [details] [review] gfileutils: Remove old win32 codepage ABI compat code
Created attachment 348858 [details] [review] giochannel: Remove old win32 codepage ABI compat code
Created attachment 348859 [details] [review] gspawn: Remove old win32 codepage ABI compat code
Created attachment 348860 [details] [review] gwin32: Remove old win32 codepage ABI compat code
Created attachment 348861 [details] [review] gmodule: Remove old win32 codepage ABI compat code
Review of attachment 348854 [details] [review]: Fine for me, see the minor comments. ::: glib/gconvert.c @@ +1847,3 @@ +/* Binary compatibility versions. Not for newly compiled code. */ + +_GLIB_EXTERN gchar* g_filename_to_utf8_utf8 (const gchar *opsysstring, * attached tot he func name @@ +1852,3 @@ + gsize *bytes_written, + GError **error) G_GNUC_MALLOC; +_GLIB_EXTERN gchar* g_filename_from_utf8_utf8 (const gchar *utf8string, same @@ +1864,3 @@ + GError **error) G_GNUC_MALLOC; + +gchar* space before * @@ +1874,3 @@ +} + +gchar* same
Review of attachment 348855 [details] [review]: Looks good.
Review of attachment 348856 [details] [review]: Looks good
Review of attachment 348857 [details] [review]: Looks good.
Review of attachment 348858 [details] [review]: Looks good.
Review of attachment 348859 [details] [review]: OK
Review of attachment 348860 [details] [review]: OK
Review of attachment 348861 [details] [review]: Please split this patch: 1. the compat stuff 2. the new comments
(In reply to Ignacio Casal Quinteiro (nacho) from comment #16) > Review of attachment 348861 [details] [review] [review]: > > Please split this patch: > 1. the compat stuff > 2. the new comments Thanks. The comments are just moved, because the functions were deleted.
Comment on attachment 348861 [details] [review] gmodule: Remove old win32 codepage ABI compat code was acked on IRC
Thanks
*** Bug 744512 has been marked as a duplicate of this bug. ***