GNOME Bugzilla – Bug 780606
Portal helper security icon not always displayed
Last modified: 2017-04-06 10:28:36 UTC
Due to a coding error, the secure icon added in bug759044 doesn't always show (in neither the secure nor insecure case). It works for the insecure-content-detected and load-failed-with-tls-errors signals but it doesn't for on-load-changed (so if I understand it correctly, when the whole page is http). Attached patch should make the issue clear.
(In reply to Catalin Iacob from comment #0) > Due to a coding error, the secure icon added in bug759044 doesn't always > show (in neither the secure nor insecure case). This should have been bug749197 instead.
Created attachment 348814 [details] [review] v1 Use the correct enum values
Review of attachment 348814 [details] [review]: Eeeks, yes. Thanks for the catch!
(In reply to Florian Müllner from comment #3) > Review of attachment 348814 [details] [review] [review]: > > Eeeks, yes. Thanks for the catch! So what happens now (not familiar with the dev process)? Will a maintainer pick this up and commit it? Do I need to do anything else?
(In reply to Catalin Iacob from comment #4) > So what happens now (not familiar with the dev process)? Will a maintainer > pick this up and commit it? Do I need to do anything else? Usually people push their own patches once they are accepted. I take from your question that you don't have commit access, so I'll push the patch ...
I swear I did test this :/