After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780533 - mutter-3.24.0 will not build without wayland
mutter-3.24.0 will not build without wayland
Product: mutter
Classification: Core
Component: general
Other Linux
: Normal major
: ---
Assigned To: mutter-maint
Depends on:
Reported: 2017-03-25 15:24 UTC by Chris Vine
Modified: 2017-05-11 12:30 UTC
See Also:
GNOME target: 3.24
GNOME version: 3.23/3.24

Compile fix for main.c (453 bytes, patch)
2017-03-25 15:24 UTC, Chris Vine
committed Details | Review
Fix for linker error (402 bytes, patch)
2017-03-25 18:58 UTC, Chris Vine
committed Details | Review

Description Chris Vine 2017-03-25 15:24:50 UTC
Created attachment 348709 [details] [review]
Compile fix for main.c

mutter-3.24.0 will not build without wayland installed, even with the --disable-wayland and --disable-wayland-egl-server options selected.

First, there is a compile error in src/core/main.c, which is easily dealt with by the patch I will attach.

However the build still fails at the linking stage for libmutter, with a linker error as follows:

make[4]: Entering directory '/usr/local/src/gnome-3/updates/mutter-3.24.0/src'
  CCLD     mutter
./.libs/ undefined reference to `meta_dnd_wayland_handle_begin_modal'
collect2: error: ld returned 1 exit status

This is with the native backend disabled.  A different set of linker errors arise when the native backend is enabled on X11.

The compiler is gcc-6.3.0 and the xorg-server is xorg-server-1.19.3.
Comment 1 Chris Vine 2017-03-25 18:58:40 UTC
Created attachment 348712 [details] [review]
Fix for linker error

This fixes the linker error.  Whether the X11 backend actually works correctly remains to be seen.
Comment 2 Ting-Wei Lan 2017-04-20 17:16:24 UTC
These two patches work for me on FreeBSD. Can they get reviewed?
Comment 3 Ting-Wei Lan 2017-05-10 15:11:17 UTC
Ping again ... mutter is a required component of any GNOME desktop installation, so I hope we don't keep it broken in git master and 3.24 releases.
Comment 4 Florian Müllner 2017-05-10 19:21:17 UTC
Can you provide a git-format'ed patch for proper attribution? The code looks good to me (though I don't see a good reason for splitting it into two patches) ...