After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780523 - playlist dialog shows the playlist that is going to be deleted which can lead to force close
playlist dialog shows the playlist that is going to be deleted which can lead...
Status: RESOLVED OBSOLETE
Product: gnome-music
Classification: Applications
Component: general
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
: 780586 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-03-25 07:24 UTC by Abhinav Singh
Modified: 2018-01-10 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
playlistdialog: Prevent display of playlist that is going to be deleted (2.36 KB, patch)
2017-03-25 07:34 UTC, Abhinav Singh 		committed Details | Review
Reset pl_todelete variables on undo (912 bytes, patch)
2017-04-14 18:24 UTC, Abhinav Singh 		none Details | Review

Description Abhinav Singh 2017-03-25 07:24:04 UTC 
Steps to reproduce:
* delete a playlist
* within 5 seconds, select a song, and click add to playlist
* playlist dialog shows up with the deleted playlist a list item
* let 5 seconds get over, now the playlist has been truly deleted
* select deleted playlist in playlist_dialog

--force close--

We should prevent the playlist that is going to be deleted from showing up in the playlist dialog.
Comment 1 Abhinav Singh 2017-03-25 07:34:03 UTC 
Created attachment 348690 [details] [review]
playlistdialog: Prevent display of playlist that is going to be deleted

During population of the dialog's list, check if the item id is equal to
the id of the playlist that is going to be deleted. If true, then do not
display the item.
Comment 2 Marinus Schraal 2017-03-26 20:03:04 UTC 
Review of attachment 348690 [details] [review]:

lgtm
Comment 3 Marinus Schraal 2017-03-27 23:45:13 UTC 
*** Bug 780586 has been marked as a duplicate of this bug. ***
Comment 4 Marinus Schraal 2017-04-03 07:45:28 UTC 
Thanks for the patch, pushed.
Comment 5 Abhinav Singh 2017-04-14 18:20:59 UTC 
Ahh I just noticed that my patch doesn't let the playlists to be shown that are deleted and undo-ed once.

Reproduce:

* delete a playlist
* undo
* playlist doesn't show up
Comment 6 Abhinav Singh 2017-04-14 18:24:30 UTC 
Created attachment 349876 [details] [review]
Reset pl_todelete variables on undo
Comment 7 Marinus Schraal 2017-04-14 21:49:31 UTC 
I can't reproduce this, for me on undo it does show up again.
Comment 8 GNOME Infrastructure Team 2018-01-10 15:03:53 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-music/issues/104.