After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780511 - Untranslatable quotation marks in about:web
Untranslatable quotation marks in about:web
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.24.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-24 20:07 UTC by Piotr Drąg
Modified: 2017-03-25 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove quotation marks from about:web page (1.31 KB, patch)
2017-03-25 14:43 UTC, Michael Catanzaro
committed Details | Review

Description Piotr Drąg 2017-03-24 20:07:57 UTC
Different languages use different quotation marks, and those visible in about:web cannot be translated.

https://git.gnome.org/browse/epiphany/tree/embed/ephy-about-handler.c#n286
Comment 1 Michael Catanzaro 2017-03-25 14:40:39 UTC
The quotation marks look bad in English. Let's just remove them.
Comment 2 Michael Catanzaro 2017-03-25 14:43:05 UTC
The following fix has been pushed:
b80fdf2 Remove quotation marks from about:web page
Comment 3 Michael Catanzaro 2017-03-25 14:43:08 UTC
Created attachment 348704 [details] [review]
Remove quotation marks from about:web page

If we keep these, then they need to be marked for translation. But we
don't need to keep them, because they look bad in English. Translators
can add them around the string if really desired, but I doubt it's ever
desired.